Skip to content

OPRUN-4546: Fix boxcutter finalizer ResourceNames in preflight test#695

Open
camilamacedo86 wants to merge 1 commit intoopenshift:mainfrom
camilamacedo86:fix-issue-ote
Open

OPRUN-4546: Fix boxcutter finalizer ResourceNames in preflight test#695
camilamacedo86 wants to merge 1 commit intoopenshift:mainfrom
camilamacedo86:fix-issue-ote

Conversation

@camilamacedo86
Copy link
Copy Markdown
Contributor

@camilamacedo86 camilamacedo86 commented Apr 9, 2026 •
edited
Loading

Motivation: #682 (comment)

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 608f989f-ca89-406e-be9b-cf778a1847e6

📥 Commits

Reviewing files that changed from the base of the PR and between afa3354 and f50ba6e.

📒 Files selected for processing (1)
  • openshift/tests-extension/test/olmv1-preflight.go

Walkthrough

A single line in the RBAC rule construction for the FeatureGateNewOLMBoxCutterRuntime enabled code path is modified in createDeficientClusterRole to set ResourceNames to a derived name using fmt.Sprintf("%s-1", ceName) instead of using ceName directly.

Changes

Cohort / File(s) Summary
RBAC Rule Modification
openshift/tests-extension/test/olmv1-preflight.go		 Updated ResourceNames field in createDeficientClusterRole for the FeatureGateNewOLMBoxCutterRuntime enabled path to use fmt.Sprintf("%s-1", ceName) instead of ceName.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from ankitathomas and trgeiger April 9, 2026 12:34
@camilamacedo86 camilamacedo86 changed the title Fix boxcutter finalizer ResourceNames in preflight test OPRUN-4546: Fix boxcutter finalizer ResourceNames in preflight test Apr 9, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 9, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 9, 2026 •
edited by openshift-ci bot
Loading

@camilamacedo86: This pull request references OPRUN-4546 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the ticket to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Motivation: #682 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Apr 9, 2026

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2026
@bandrade
Copy link
Copy Markdown
Contributor

bandrade commented Apr 9, 2026

/label qe-approved
/verified by @bandrade

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 9, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 9, 2026 •
edited by openshift-ci bot
Loading

@camilamacedo86: This pull request references OPRUN-4546 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the ticket to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Motivation: #682 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 9, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 9, 2026

@bandrade: This PR has been marked as verified by @bandrade.

Details

In response to this:

/label qe-approved
/verified by @bandrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot bot commented Apr 9, 2026

/retest-required

Remaining retests: 0 against base HEAD 5f801ad and 2 for PR HEAD f50ba6e in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 9, 2026

@camilamacedo86: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openshift-e2e-aws f50ba6e link unknown /test openshift-e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@camilamacedo86
Copy link
Copy Markdown
Contributor Author

camilamacedo86 commented Apr 10, 2026

/test openshift-e2e-aws

@camilamacedo86
Copy link
Copy Markdown
Contributor Author

camilamacedo86 commented Apr 10, 2026

/retest-required

@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Apr 10, 2026

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@trgeiger trgeiger Awaiting requested review from trgeiger

Assignees

@tmshort tmshort

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@camilamacedo86 @openshift-ci-robot @tmshort @bandrade